Dorian Eikenberg

https://github.com/rust-lang/cargo/issues/1197 :(

You should not change anything in the existing tests. They are fine as there are right now. Even worse, your changes to them are causing runtime errors.

Looks like you have not addressed any comments from my previous review.

@Wenzel Will do 👍

Imho the microvmi struct looks a bit overly complicated. I would prefer a design where you (as a library user) initialize the driver like we used to and then pass...

> Yes, when I tried to implement it, I have issues with the lifetimes and such, so I gave up. You could use reference counting instead. I know this is...

I often use weak pointers in event callbacks for the vmi implementation in my company. Helps to alleviate segfaults. ;)

Here is an idea: Why don't we have something like an event supervisor? The only way to listen for events is to register callbacks with the event supervisor. This would...

The function you have linked is used to retrieve internally stored vmi events, so that's something entirely different. We are now unable to read page permissions via kvmi. In Xen...

The idea looks good to me. I have one small note though: Why use a hash map? Wouldn't it be nicer to use a complex enum where each enum variant...