libmicrovmi
libmicrovmi copied to clipboard
Unit tests
Do not merge until previous ones are merged!
Do not merge until previous ones have been merged!
@arnabcs17b006 same question here ?
Yes.. It is relevant
On Thu, Aug 20, 2020, 04:37 Mathieu Tarral [email protected] wrote:
@arnabcs17b006 https://github.com/arnabcs17b006 same question here ?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Wenzel/libmicrovmi/pull/82#issuecomment-676801291, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALGMDC5ZGNQLMANLOT3RMNLSBRLLFANCNFSM4OEQPDLQ .
Then I think you need a rebase too
You should not change anything in the existing tests. They are fine as there are right now. Even worse, your changes to them are causing runtime errors.
Looks like you have not addressed any comments from my previous review.
Codecov Report
Merging #82 into master will increase coverage by
52.35%
. The diff coverage is91.58%
.
@@ Coverage Diff @@
## master #82 +/- ##
===========================================
+ Coverage 16.73% 69.09% +52.35%
===========================================
Files 5 5
Lines 472 990 +518
Branches 65 104 +39
===========================================
+ Hits 79 684 +605
+ Misses 382 219 -163
- Partials 11 87 +76
Flag | Coverage Δ | |
---|---|---|
#unittests | 69.09% <91.58%> (+52.35%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/api.rs | 1.06% <0.00%> (+1.06%) |
:arrow_up: |
src/driver/kvm.rs | 84.42% <92.45%> (+57.27%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c0d5537...51d3d67. Read the comment docs.