Ankit Jain

Results 267 comments of Ankit Jain

Why are we updating this version, and only for this specific project? Do we need to update `$(NewtonsoftJsonVersion)` too? ```xml eng/Versions.props: 12.0.3 eng/testing/xunit/xunit.props: src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj: ```

re:having-spin-or-nonblocking-in-fn-name, I added those to make it obvious to spot cases where they might get used in incorrect contexts. For example, using a spin wait for a state inside a...

Latest main has an issue with linker - https://github.com/dotnet/linker/issues/2963

[Wasm samples failing with:](https://dev.azure.com/dnceng/public/_build/results?buildId=1935580&view=logs&jobId=11c5c840-d20a-5536-428b-70d8cd9c6259&j=11c5c840-d20a-5536-428b-70d8cd9c6259&t=cdae1c92-5397-500e-687d-b0aafc3f5e3d): ``` /__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/native/System.Private.CoreLib.dll : error IL2104: Assembly 'System.Private.CoreLib' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/browser/Wasm.Browser.Sample.csproj] /__w/1/s/.dotnet/sdk/7.0.100-preview.5.22307.18/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(110,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can...

The debugger test failure is https://github.com/dotnet/runtime/issues/73528 .

I was able to artificially reproduce this by calling moving `App.runtime = runtime; App.init();` to run after a timeout.

Having an event/message that indicates "app is ready", and having "app is ready" as formal thing would be helpful. As a workaround, I can add a special message for this...

@lewing do we need to run debugger tests with relinking?