runtime icon indicating copy to clipboard operation
runtime copied to clipboard

[main] Update dependencies from dotnet/linker

Open dotnet-maestro[bot] opened this issue 2 years ago • 1 comments

This pull request updates the following dependencies

From https://github.com/dotnet/linker

  • Subscription: 0d6d6ae4-f71f-4395-53e6-08d8e409d87d
  • Build: 20220805.1
  • Date Produced: August 6, 2022 3:03:48 AM UTC
  • Commit: dede5f58dc9b7296de884ed62688b35d5b154b78
  • Branch: refs/heads/main

dotnet-maestro[bot] avatar Aug 04 '22 22:08 dotnet-maestro[bot]

cc @vitek-karas

lewing avatar Aug 05 '22 17:08 lewing

@sbomer is looking into this

vitek-karas avatar Aug 08 '22 12:08 vitek-karas

Once the "linker can't run" problem is fixed, there will be additional failures caused by fixes in the linker (runtime has wrong/missing suppression in some places). @jkurdek is working fixing these.

vitek-karas avatar Aug 09 '22 13:08 vitek-karas

@jkurdek the runtime version issue is resolved now, and the new warnings are showing up.

sbomer avatar Aug 10 '22 00:08 sbomer

Latest main has an issue with linker - https://github.com/dotnet/linker/issues/2963

radical avatar Aug 10 '22 00:08 radical

Wasm samples failing with::

/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/native/System.Private.CoreLib.dll : error IL2104: Assembly 'System.Private.CoreLib' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/browser/Wasm.Browser.Sample.csproj]
/__w/1/s/.dotnet/sdk/7.0.100-preview.5.22307.18/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(110,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false. [/__w/1/s/src/mono/sample/wasm/browser/Wasm.Browser.Sample.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/native/System.Private.CoreLib.dll : error IL2104: Assembly 'System.Private.CoreLib' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/console-node/Wasm.Console.Node.Sample.csproj]
/__w/1/s/.dotnet/sdk/7.0.100-preview.5.22307.18/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(110,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false. [/__w/1/s/src/mono/sample/wasm/console-node/Wasm.Console.Node.Sample.csproj]

/_/src/mono/sample/wasm/browser-bench/Json.cs(43,13): Trim analysis error IL2121: Sample.JsonTask.Initialize(): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/_/src/mono/sample/wasm/browser-bench/Json.cs(113,47): Trim analysis error IL2121: Sample.JsonTask.LargeDeserialize.RunStep(): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/_/src/mono/sample/wasm/browser-bench/Json.cs(101,47): Trim analysis error IL2121: Sample.JsonTask.LargeSerialize.RunStep(): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/_/src/mono/sample/wasm/browser-bench/Json.cs(89,47): Trim analysis error IL2121: Sample.JsonTask.SmallDeserialize.RunStep(): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/_/src/mono/sample/wasm/browser-bench/Json.cs(78,47): Trim analysis error IL2121: Sample.JsonTask.SmallSerialize.RunStep(): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/_/src/mono/sample/wasm/browser-bench/Program.cs(45,13): Trim analysis error IL2121: Sample.Test.SetTasks(String): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2057'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/_/src/mono/sample/wasm/browser-bench/Program.cs(45,13): Trim analysis error IL2121: Sample.Test.SetTasks(String): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2072'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/_/src/mono/sample/wasm/browser-bench/Json.cs(67,47): Trim analysis error IL2121: Sample.JsonTask.TextDeserialize.RunStep(): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/_/src/mono/sample/wasm/browser-bench/Json.cs(56,47): Trim analysis error IL2121: Sample.JsonTask.TextSerialize.RunStep(): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]

/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/lib/net7.0/System.ComponentModel.TypeConverter.dll : error IL2104: Assembly 'System.ComponentModel.TypeConverter' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/lib/net7.0/System.Runtime.InteropServices.JavaScript.dll : error IL2104: Assembly 'System.Runtime.InteropServices.JavaScript' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/lib/net7.0/System.Text.Json.dll : error IL2104: Assembly 'System.Text.Json' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/native/System.Private.CoreLib.dll : error IL2104: Assembly 'System.Private.CoreLib' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/__w/1/s/.dotnet/sdk/7.0.100-preview.5.22307.18/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(110,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/native/System.Private.CoreLib.dll : error IL2104: Assembly 'System.Private.CoreLib' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/console-v8/Wasm.Console.V8.Sample.csproj]
/__w/1/s/.dotnet/sdk/7.0.100-preview.5.22307.18/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(110,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false. [/__w/1/s/src/mono/sample/wasm/console-v8/Wasm.Console.V8.Sample.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/native/System.Private.CoreLib.dll : error IL2104: Assembly 'System.Private.CoreLib' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/browser-profile/Wasm.BrowserProfile.Sample.csproj]
/__w/1/s/.dotnet/sdk/7.0.100-preview.5.22307.18/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(110,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false. [/__w/1/s/src/mono/sample/wasm/browser-profile/Wasm.BrowserProfile.Sample.csproj]

Library tests on wasm built with trimming failing:

/_/src/libraries/System.Runtime/tests/System/Type/TypeTests.cs(158,13): Trim analysis error IL2121: System.Tests.TypeTests.FindMembers_Invoke_ReturnsExpected(MemberTypes, BindingFlags, MemberFilter, Object, Int32): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2118'. Consider removing the unused warning suppression. [/__w/1/s/src/libraries/System.Runtime/tests/System.Runtime.Tests.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/lib/net7.0/System.ComponentModel.TypeConverter.dll : error IL2104: Assembly 'System.ComponentModel.TypeConverter' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/libraries/System.Runtime/tests/System.Runtime.Tests.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/lib/net7.0/System.Linq.Expressions.dll : error IL2104: Assembly 'System.Linq.Expressions' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/libraries/System.Runtime/tests/System.Runtime.Tests.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/lib/net7.0/System.Linq.Queryable.dll : error IL2104: Assembly 'System.Linq.Queryable' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/libraries/System.Runtime/tests/System.Runtime.Tests.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/lib/net7.0/System.Runtime.InteropServices.JavaScript.dll : error IL2104: Assembly 'System.Runtime.InteropServices.JavaScript' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/libraries/System.Runtime/tests/System.Runtime.Tests.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/native/System.Private.CoreLib.dll : error IL2104: Assembly 'System.Private.CoreLib' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/libraries/System.Runtime/tests/System.Runtime.Tests.csproj]
/__w/1/s/.dotnet/sdk/7.0.100-preview.5.22307.18/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(110,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false. [/__w/1/s/src/libraries/System.Runtime/tests/System.Runtime.Tests.csproj]

radical avatar Aug 11 '22 01:08 radical

/azp run runtime-wasm-perf

radical avatar Aug 11 '22 02:08 radical

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 11 '22 02:08 azure-pipelines[bot]

@radical I tried to disable IL2121 in the wasm samples as well. Would you be able to do the same anywhere else that it needs to be disabled for wasm? I believe this can be undone with a preview6 SDK (which should import linker targets from the latest package, where we disable the warning).

sbomer avatar Aug 11 '22 16:08 sbomer

/azp run runtime-wasm-perf

vitek-karas avatar Aug 12 '22 12:08 vitek-karas

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 12 '22 12:08 azure-pipelines[bot]

/azp run runtime-wasm-perf

vitek-karas avatar Aug 12 '22 14:08 vitek-karas

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 12 '22 14:08 azure-pipelines[bot]

The only failure is linux_musl arm64 libraries test run timing out which is happening other PRs as well.

vitek-karas avatar Aug 12 '22 17:08 vitek-karas