runtime icon indicating copy to clipboard operation
runtime copied to clipboard
verified publisher icon dotnet

[wasm] crypto deadlock fix

Open pavelsavara opened this issue 3 years ago • 1 comments

  • more locking before manipulation with the channel state.
  • more asserts about expected states
  • removed extra console.debug logging
  • renamed wait method to make it clearer what we are waiting for

pavelsavara avatar Aug 07 '22 19:08 pavelsavara

Tagging subscribers to 'arch-wasm': @lewing See info in area-owners.md if you want to be subscribed.

Issue Details
  • more locking before manipulation with the channel state.
  • more asserts about expected states
  • removed extra console.debug logging
  • renamed wait method to make it clearer what we are waiting for
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 7.0.0

msftbot[bot] avatar Aug 07 '22 19:08 msftbot[bot]

CI test with multiple workitems on Helix is https://github.com/dotnet/runtime/pull/73629

pavelsavara avatar Aug 09 '22 16:08 pavelsavara

re:having-spin-or-nonblocking-in-fn-name, I added those to make it obvious to spot cases where they might get used in incorrect contexts. For example, using a spin wait for a state inside a lock, which could cause a deadlock because the other side is waiting for that lock, so it can change the state.

radical avatar Aug 10 '22 01:08 radical

/azp run runtime-wasm

pavelsavara avatar Aug 10 '22 09:08 pavelsavara

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 10 '22 09:08 azure-pipelines[bot]