Arnout Engelen

Results 679 comments of Arnout Engelen

~hmm but the `nix build` cli doesn't seem to expose an equivalent flag?~ Ah `--option keep-going true` Still seems to only invoke the diff-hook for the failure and not the...

that sounds reasonable - perhaps the other way around would be slightly nicer? i.e. could we change the scala 2.12 build settings not to treat warnings as errors?

> Cool, thanks @raboof, but I think we can wait for the 3.3.5 release too, which keeps the same behavior. We could, but we don't have to, and I think...

applied the fix to determine the logging class from the stack trace from https://github.com/apache/pekko/pull/1474#issuecomment-2363209801 . I don't think we need to worry about performance here: the added logic should be...

Ah, the intent was for those to get added to the `failed` list but it's very possible I messed up the error handling somewhere. A backtrace would've been good but...

(rebased to fix conflicts but haven't looked into the error handling yet, somewhere in the next few days, I'll self-assign when I start work on it)

> I would suggest just to make a new test-repo and add a new test case. It's not a good practice to edit the VCR cassettes by hand unless very...

Hmm, I guess we could have a bunch of regexes, like indeed links to the GitHub security reporting mechanism and texts like "report(ing)? a vulnerability", "to report a (new)? vulnerability",...

I'm not aware of any plans in that area

Looks like with #4376 this can now be closed, right?