Arnout Engelen

Results 679 comments of Arnout Engelen

It's an interesting observation that https://pekko.apache.org/japi/pekko/snapshot/org/apache/pekko/stream/javadsl/Flow.html#collect(scala.PartialFunction) is present on the Java API, but uses `scala.PartialFunction`. We do supply some helper methods to make it easier to create Scala partial functions...

> The entire pekko-stream codebase is all designed with the assumption that `null` is never going to be any element As far as I understand, the operator proposed in the...

> > > The entire pekko-stream codebase is all designed with the assumption that `null` is never going to be any element > > > > > > As far...

> I think the `asStream` can be non-blocking, only triggering a pull when there is a `hasNext` request, and letting the poller who consumes the Java stream wait on the...

> > The warning there (which is also in your javadoc/scaladoc) is that this will use blocking operations. That could be a reason to discourage this API, and putting them...

The current implementation uses `Await.result` in `Iterator.hasNext`. It might be possible to create an implementation that avoids blocking - or at least avoids it as long as the user doesn't...

No, `--rebuild` will not on its own keep the build dir, it needs `--keep-failed` for that (but that only keeps it when it fails). Of course you can work around...

Looks like adding an option means changing the protocol between the client and the daemon, which introduces a bunch of ceremony. For now I'm just applying this locally ```patch commit...

That seems reasonable for a 2.0.x to me, yes

recording a screenshot here to better understand what you're referring to once your PR has gone through: While I agree the reference to `cfg` is confusing here, I'm not sure...