pekko icon indicating copy to clipboard operation
pekko copied to clipboard

Update scala-library to 2.13.15

Open scala-steward-asf[bot] opened this issue 1 year ago • 3 comments

About this PR

📦 Updates org.scala-lang:scala-library from 2.13.14 to 2.13.15

📜 GitHub Release Notes - Version Diff

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

🔍 Files still referring to the old version number

The following files still refer to the old version number (2.13.14). You might want to review and update them manually.

scripts/link-validator.conf
⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala-library" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang", artifactId = "scala-library" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

scala-steward-asf[bot] avatar Sep 29 '24 00:09 scala-steward-asf[bot]

original build was failing due to @warn annotations that are not needed

pjfanning avatar Oct 03 '24 00:10 pjfanning

It looks like at least some of the @nowarn annotations are needed in the Scala 2.12 build but that Scala 2.13.15 fails if they are there. I think the best solution is to leave them there and change the Scala 2.13 build settings to not fail if there are unnecessary @nowarn annotations.

pjfanning avatar Oct 03 '24 11:10 pjfanning

that sounds reasonable - perhaps the other way around would be slightly nicer? i.e. could we change the scala 2.12 build settings not to treat warnings as errors?

raboof avatar Oct 03 '24 11:10 raboof

I tried locally, seems too hard to keep three Scala versions :( wait https://github.com/scala/scala3/issues/21818

He-Pin avatar Dec 01 '24 07:12 He-Pin

Cool, thanks @raboof, but I think we can wait for the 3.3.5 release too, which keeps the same behavior.

He-Pin avatar Jan 03 '25 14:01 He-Pin

Cool, thanks @raboof, but I think we can wait for the 3.3.5 release too, which keeps the same behavior.

We could, but we don't have to, and I think it's useful to get these updates in small chunks instead of large ones - so I'd still propose we merge this.

raboof avatar Jan 03 '25 17:01 raboof