pekko icon indicating copy to clipboard operation
pekko copied to clipboard
verified publisher icon apache

Update scala3-library to 3.3.4

Open scala-steward-asf[bot] opened this issue 1 year ago • 1 comments

About this PR

📦 Updates org.scala-lang:scala3-library from 3.3.3 to 3.3.4

📜 GitHub Release Notes - Version Diff - Version Diff

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala3-library" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang", artifactId = "scala3-library" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, version-scheme:semver-spec, commit-count:1

scala-steward-asf[bot] avatar Sep 29 '24 00:09 scala-steward-asf[bot]

Breaks some tests that check logging

2024-10-03T00:08:58.4024268Z [10-03 00:08:58.399] [0m[[0m[0minfo[0m] [0m[0m[31m- must always log user message in context.log *** FAILED *** (6 seconds, 15 milliseconds)[0m[0m
2024-10-03T00:08:58.4028706Z [10-03 00:08:58.400] [0m[[0m[0minfo[0m] [0m[0m[31m  java.lang.AssertionError: Timeout (6 seconds) waiting for 1 messages on LoggingTestKitImpl(1,Some(INFO),Some(org.apache.pekko.persistence.typed.EventSourcedBehaviorLoggingSpec$ChattyEventSourcingBehavior$),None,Some(received message 'Mary'),None,None,Map(),true,None).[0m[0m
2024-10-03T00:08:58.4032991Z [10-03 00:08:58.400] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.apache.pekko.actor.testkit.typed.internal.LoggingTestKitImpl.expect(LoggingTestKitImpl.scala:113)[0m[0m
2024-10-03T00:08:58.4036169Z [10-03 00:08:58.400] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.apache.pekko.persistence.typed.EventSourcedBehaviorLoggingSpec.f$proxy1$1(EventSourcedBehaviorLoggingSpec.scala:86)[0m[0m
2024-10-03T00:08:58.4039513Z [10-03 00:08:58.400] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.apache.pekko.persistence.typed.EventSourcedBehaviorLoggingSpec.$init$$$anonfun$1$$anonfun$1(EventSourcedBehaviorLoggingSpec.scala:87)[0m[0m
2024-10-03T00:08:58.4042304Z [10-03 00:08:58.400] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.Transformer.apply$$anonfun$1(Transformer.scala:22)[0m[0m
2024-10-03T00:08:58.4044345Z [10-03 00:08:58.400] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)[0m[0m
2024-10-03T00:08:58.4046302Z [10-03 00:08:58.400] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:31)[0m[0m
2024-10-03T00:08:58.4048265Z [10-03 00:08:58.400] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)[0m[0m
2024-10-03T00:08:58.4050216Z [10-03 00:08:58.401] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.Transformer.apply(Transformer.scala:22)[0m[0m
2024-10-03T00:08:58.4052666Z [10-03 00:08:58.401] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.Transformer.apply(Transformer.scala:21)[0m[0m
2024-10-03T00:08:58.4054846Z [10-03 00:08:58.401] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.wordspec.AnyWordSpecLike$$anon$3.apply(AnyWordSpecLike.scala:1118)[0m[0m
2024-10-03T00:08:58.4057421Z [10-03 00:08:58.401] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.apache.pekko.actor.testkit.typed.scaladsl.LogCapturing.withFixture(LogCapturing.scala:79)[0m[0m
2024-10-03T00:08:58.4060245Z [10-03 00:08:58.401] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.apache.pekko.actor.testkit.typed.scaladsl.LogCapturing.withFixture$(LogCapturing.scala:42)[0m[0m
2024-10-03T00:08:58.4063305Z [10-03 00:08:58.401] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.apache.pekko.persistence.typed.EventSourcedBehaviorLoggingSpec.withFixture(EventSourcedBehaviorLoggingSpec.scala:64)[0m[0m
2024-10-03T00:08:58.4066225Z [10-03 00:08:58.401] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.wordspec.AnyWordSpecLike.invokeWithFixture$1(AnyWordSpecLike.scala:1124)[0m[0m
2024-10-03T00:08:58.4068654Z [10-03 00:08:58.401] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.wordspec.AnyWordSpecLike.runTest$$anonfun$1(AnyWordSpecLike.scala:1128)[0m[0m
2024-10-03T00:08:58.4076205Z [10-03 00:08:58.401] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.SuperEngine.runTestImpl(Engine.scala:306)[0m[0m
2024-10-03T00:08:58.4078598Z [10-03 00:08:58.401] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.wordspec.AnyWordSpecLike.runTest(AnyWordSpecLike.scala:1128)[0m[0m
2024-10-03T00:08:58.4080749Z [10-03 00:08:58.402] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.wordspec.AnyWordSpecLike.runTest$(AnyWordSpecLike.scala:44)[0m[0m
2024-10-03T00:08:58.4083716Z [10-03 00:08:58.402] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.apache.pekko.persistence.typed.EventSourcedBehaviorLoggingSpec.runTest(EventSourcedBehaviorLoggingSpec.scala:64)[0m[0m
2024-10-03T00:08:58.4086714Z [10-03 00:08:58.402] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.wordspec.AnyWordSpecLike.runTests$$anonfun$1(AnyWordSpecLike.scala:1187)[0m[0m
2024-10-03T00:08:58.4089111Z [10-03 00:08:58.402] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.SuperEngine.traverseSubNodes$1$$anonfun$1(Engine.scala:413)[0m[0m
2024-10-03T00:08:58.4091103Z [10-03 00:08:58.402] [0m[[0m[0minfo[0m] [0m[0m[31m  at scala.runtime.function.JProcedure1.apply(JProcedure1.java:15)[0m[0m
2024-10-03T00:08:58.4093345Z [10-03 00:08:58.402] [0m[[0m[0minfo[0m] [0m[0m[31m  at scala.runtime.function.JProcedure1.apply(JProcedure1.java:10)[0m[0m
2024-10-03T00:08:58.4095462Z [10-03 00:08:58.402] [0m[[0m[0minfo[0m] [0m[0m[31m  at scala.collection.immutable.List.foreach(List.scala:334)[0m[0m
2024-10-03T00:08:58.4097299Z [10-03 00:08:58.402] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:429)[0m[0m
2024-10-03T00:08:58.4099319Z [10-03 00:08:58.403] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.SuperEngine.runTestsInBranch(Engine.scala:390)[0m[0m
2024-10-03T00:08:58.4101404Z [10-03 00:08:58.403] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.SuperEngine.traverseSubNodes$1$$anonfun$1(Engine.scala:427)[0m[0m
2024-10-03T00:08:58.4103385Z [10-03 00:08:58.403] [0m[[0m[0minfo[0m] [0m[0m[31m  at scala.runtime.function.JProcedure1.apply(JProcedure1.java:15)[0m[0m
2024-10-03T00:08:58.4105601Z [10-03 00:08:58.403] [0m[[0m[0minfo[0m] [0m[0m[31m  at scala.runtime.function.JProcedure1.apply(JProcedure1.java:10)[0m[0m
2024-10-03T00:08:58.4107529Z [10-03 00:08:58.403] [0m[[0m[0minfo[0m] [0m[0m[31m  at scala.collection.immutable.List.foreach(List.scala:334)[0m[0m
2024-10-03T00:08:58.4109473Z [10-03 00:08:58.403] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:429)[0m[0m
2024-10-03T00:08:58.4111521Z [10-03 00:08:58.403] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.SuperEngine.runTestsInBranch(Engine.scala:396)[0m[0m
2024-10-03T00:08:58.4113478Z [10-03 00:08:58.403] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.SuperEngine.runTestsImpl(Engine.scala:475)[0m[0m
2024-10-03T00:08:58.4115562Z [10-03 00:08:58.403] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.wordspec.AnyWordSpecLike.runTests(AnyWordSpecLike.scala:1187)[0m[0m
2024-10-03T00:08:58.4117803Z [10-03 00:08:58.403] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.wordspec.AnyWordSpecLike.runTests$(AnyWordSpecLike.scala:44)[0m[0m
2024-10-03T00:08:58.4121093Z [10-03 00:08:58.404] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.apache.pekko.persistence.typed.EventSourcedBehaviorLoggingSpec.runTests(EventSourcedBehaviorLoggingSpec.scala:64)[0m[0m
2024-10-03T00:08:58.4123411Z [10-03 00:08:58.404] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.Suite.run(Suite.scala:1114)[0m[0m
2024-10-03T00:08:58.4124820Z [10-03 00:08:58.404] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.Suite.run$(Suite.scala:564)[0m[0m
2024-10-03T00:08:58.4127261Z [10-03 00:08:58.404] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.apache.pekko.actor.testkit.typed.scaladsl.ScalaTestWithActorTestKit.org$scalatest$BeforeAndAfterAll$$super$run(ScalaTestWithActorTestKit.scala:41)[0m[0m
2024-10-03T00:08:58.4135206Z [10-03 00:08:58.404] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.BeforeAndAfterAll.liftedTree1$1(BeforeAndAfterAll.scala:213)[0m[0m
2024-10-03T00:08:58.4137515Z [10-03 00:08:58.404] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.BeforeAndAfterAll.run(BeforeAndAfterAll.scala:217)[0m[0m
2024-10-03T00:08:58.4139560Z [10-03 00:08:58.404] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.BeforeAndAfterAll.run$(BeforeAndAfterAll.scala:135)[0m[0m
2024-10-03T00:08:58.4141687Z [10-03 00:08:58.404] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.apache.pekko.persistence.typed.EventSourcedBehaviorLoggingSpec.org$scalatest$wordspec$AnyWordSpecLike$$super$run(EventSourcedBehaviorLoggingSpec.scala:64)[0m[0m
2024-10-03T00:08:58.4145846Z [10-03 00:08:58.404] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.wordspec.AnyWordSpecLike.run$$anonfun$1(AnyWordSpecLike.scala:1232)[0m[0m
2024-10-03T00:08:58.4147733Z [10-03 00:08:58.405] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.SuperEngine.runImpl(Engine.scala:535)[0m[0m
2024-10-03T00:08:58.4149605Z [10-03 00:08:58.405] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.wordspec.AnyWordSpecLike.run(AnyWordSpecLike.scala:1232)[0m[0m
2024-10-03T00:08:58.4152148Z [10-03 00:08:58.405] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.wordspec.AnyWordSpecLike.run$(AnyWordSpecLike.scala:44)[0m[0m
2024-10-03T00:08:58.4153963Z [10-03 00:08:58.405] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.apache.pekko.persistence.typed.EventSourcedBehaviorLoggingSpec.run(EventSourcedBehaviorLoggingSpec.scala:64)[0m[0m
2024-10-03T00:08:58.4156600Z [10-03 00:08:58.405] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.tools.Framework.org$scalatest$tools$Framework$$runSuite(Framework.scala:321)[0m[0m
2024-10-03T00:08:58.4158819Z [10-03 00:08:58.405] [0m[[0m[0minfo[0m] [0m[0m[31m  at org.scalatest.tools.Framework$ScalaTestTask.execute(Framework.scala:517)[0m[0m
2024-10-03T00:08:58.4160733Z [10-03 00:08:58.405] [0m[[0m[0minfo[0m] [0m[0m[31m  at sbt.ForkMain$Run.lambda$runTest$1(ForkMain.java:414)[0m[0m
2024-10-03T00:08:58.4162703Z [10-03 00:08:58.405] [0m[[0m[0minfo[0m] [0m[0m[31m  at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)[0m[0m
2024-10-03T00:08:58.4165043Z [10-03 00:08:58.406] [0m[[0m[0minfo[0m] [0m[0m[31m  at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)[0m[0m
2024-10-03T00:08:58.4167619Z [10-03 00:08:58.406] [0m[[0m[0minfo[0m] [0m[0m[31m  at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)[0m[0m
2024-10-03T00:08:58.4169589Z [10-03 00:08:58.406] [0m[[0m[0minfo[0m] [0m[0m[31m  at java.base/java.lang.Thread.run(Thread.java:829)[0m[0m

pjfanning avatar Oct 03 '24 00:10 pjfanning

applied the fix to determine the logging class from the stack trace from https://github.com/apache/pekko/pull/1474#issuecomment-2363209801 . I don't think we need to worry about performance here: the added logic should be much faster than the time it already takes to construct the stack trace in the first place.

raboof avatar Oct 07 '24 10:10 raboof