Nate Lampton
Nate Lampton
Thanks folks! A nice easy fix. Sorry this took so long to pull in. I've merged https://github.com/backdrop/backdrop/pull/4270 into 1.x and 1.26.x. Thanks @argiepiano, @alanmels, @bugfolder, and @kiamlaluno!
Thanks everyone! I merged https://github.com/backdrop/backdrop/pull/4372 into 1.x and 1.24.x. Extra thanks to @sudipto68 for reporting this issue and with such detail! https://github.com/backdrop/backdrop/commit/f695ee8717361df24083e5080e438abed95914eb by @herbdool, @indigoxela, @sudipto68, @klonos, and @argiepiano.
I'd like to advocate for this issue once I complete https://github.com/backdrop/backdrop-issues/issues/5748.
I took a look at this PR and it works great! > I've updated the PR but leaving this as 'needs work' because I can't get the 'plain text' option...
I filed a new PR at https://github.com/backdrop/backdrop/pull/4423 that is ready for testing. Still working on tests.
Thanks @klonos, I plan to imitate the tests from the Drupal issue. I reworked my PR a bit because I found that previously that a list of allowed formats was...
I ported the tests from the Drupal issue. They're not quite as comprehensive as I would have hoped but it covers the basic concepts of showing/hiding text formats based on...
Testing instructions: * Log in as admin to the sandbox * Visit `admin/structure/types/manage/page/fields/body` * Disable a text format, such as "Raw HTML". * Visit `node/add/page` * Confirm the selected text...
Thanks @laryn, @stpaultim, and @klonos for reviewing! I have merged https://github.com/backdrop/backdrop/pull/4423 into 1.x for 1.25.0! Big thanks to @BWPanda for making the original PR!
Looks good to me @jenlampton. Ready to publish!