Nate Lampton

Results 508 comments of Nate Lampton

I merged https://github.com/backdrop/backdrop/pull/4868 into 1.x and 1.28.x. Thank you @jenlampton for making the PR! Thanks @indigoxela and @izmeez for feedback!

:sweat_smile: Thanks for your testing @indigoxela!

> What I find a bit irritating is, that for RTL languages, the box shadow always appears, even if far from the window edge (and no overlap). Nice catch @indigoxela....

Confirmed @jenlampton's changes work as expected. The additional dropshadow and border are added only after the menu begins to wrap, both in LTR and RTL languages.

I merged https://github.com/backdrop/backdrop/pull/4869 into 1.x for 1.29.0. Thank you @wesruv for creating the issue and filing the initial PR! https://github.com/backdrop/backdrop/commit/5aa692b454197e25ef0936e8c74550b1e6b59966 by @wesruv, @jenlampton, @izmeez, @indigoxela, and @quicksketch.

I wasn't sure about checking `$_GET['destinations']` as the indicator as to whether a field was new or not, but it does work and the risk is very low here. Since...

@argiepiano Could you check my code comment here: https://github.com/backdrop/backdrop/pull/4845#pullrequestreview-2447851252 Overall looks great to me. The update hook makes sense and only bothers users if there's something to actually update. Looks...

@argiepiano Thanks! I tested this both with and without any `.keynote` files in my files directory and it works well in both scenarios. I think this could be slightly improved...

Tested and validated. Works great! ![image](https://github.com/user-attachments/assets/e0481047-1fe4-45da-a283-8dbc9d312eee)

Yay, perfect, thank you @argiepiano! I merged https://github.com/backdrop/backdrop/pull/4845 into 1.x and 1.29.x. I'm sorry this didn't get into today's release. But since it was a security release and this issue...