Nate Lampton

Results 508 comments of Nate Lampton

Great point @laryn, I completely forgot that `#type = link` already creates an `` tag. Please disregard my comments about renaming `link` to `link_field` then. :slightly_smiling_face: > I think we...

@argiepiano I posted a code review and found several areas that could use some improvement. And I have a few questions, it seems like there might be unused properties being...

Thank you @positron96, this was the issue for me. I reconverted my 8-bit wav files from their original sources to 16-bit and a noticeable fuzz at both the beginning and...

I'd love to get this in the next release, as we don't have time for this in 1.1.0.

Hey @docwilmot, it's been a year since this work but I have to say: this is great! I tried out your PR and it actually nearly works! Very cool! In...

Not sure how this got in 1.15.1. It should be backwards compatible when finished, but it's a pretty big change (and not a bug fix). I'd be happy to have...

@docwilmot refreshed his PR at https://github.com/backdrop/backdrop/pull/3755. I gave it a code review and it's looking great. Still lots of test failures related to File module.

> but could/should we introduce a new `file_save_upload_multiple()` function. Yes, I think that may be a great approach and limit the complexity inside of `file_save_upload()`. We could potentially extract the...

Merged this into 1.x and 1.29.x. Thank you @indigoxela and @herbdool for reviewing!

Release notes draft: --- Maintenance release for Backdrop CMS. This update contains bug fixes and usability improvements only. **Notes for updating** * No changes have been made to the `.htaccess`,...