qlrd

Results 34 comments of qlrd

@IvanOnishchenko Issue's and steps reproduced here (with electron 13 and electron-builder). Resolved only with the solution proposed by @mcous: downgrade the `usb-detection ^4.14.0` to `[email protected]`.

> Is there any workaround for now? > > Update: as a workaround, I was able to fix my builds by patching my local copy of `site-packages/kivy/tools/packaging/pyinstaller_hooks/__init__.py` with the changes...

Should the installer prevent older versions too?

Interesting concept. IMO, while it's better to separate SDCards for different purposes, it's a balance between with what's is possible for some users and security.

> Just to be sure and compliant to new PR template: Were tests made also on devices? I made a test only in amigo, i will try in another one...

> Thank you @tadeubas for the review, sorry for merging the PR before it. Thanks too @tadeubas! > @qlrd please do a new PR with fixes! Sure!

> List all devices to be checked could be useful only before a release, not development. For the template we could just change the "Yes" to Yes, build and tested...

There's a fix for this issue?

> that would be great to reserve mnemonic phrase along with wallet descryptor via QR/file to eliminate manual setup for every sign in multisign. Currently, IMO, this could be hard...

@spatcho, reviewed a little your changes and there're some broken tests: ```bash FAILED tests/printers/test_cnc.py::test_print_qr_code_with_row_cutmethod - TypeError: unsupported operand type(s) for &: 'str' and 'int' FAILED tests/printers/test_cnc.py::test_print_qr_code_with_spiral_cutmethod - TypeError: unsupported operand...