Save qrcode as svg image
What is this PR for?
partially fix of #550 and #557
Changes made to:
- [x] Code
- [x] Tests
- [ ] Docs
- [x] CHANGELOG
Did you build the code and tested on device?
- [x] Yes
What is the purpose of this pull request?
- [ ] Bug fix
- [x] New feature
- [ ] Docs update
- [ ] Other
Details
This draft PR is a followup of great work made by @spatcho in #557, just filtering the specific changes on the topic SVG through git patches. Basically, "Save encrypted qrcode as svg image".
Also, this PR cover 100% of src/krux/qr_view.py.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.42%. Comparing base (
c7721e9) to head (eb90328). Report is 4 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #585 +/- ##
===========================================
+ Coverage 95.34% 95.42% +0.07%
===========================================
Files 76 76
Lines 8619 8650 +31
===========================================
+ Hits 8218 8254 +36
+ Misses 401 396 -5
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Just to be sure and compliant to new PR template: Were tests made also on devices?
Just to be sure and compliant to new PR template: Were tests made also on devices?
I made a test only in amigo, i will try in another one -- but i do not have m5stick anymore :(
I believe this is something which behavior won't change in different devices. Merging now, thanks!
Thank you @tadeubas for the review, sorry for merging the PR before it. @qlrd please do a new PR with fixes!
Thank you @tadeubas for the review, sorry for merging the PR before it.
Thanks too @tadeubas!
@qlrd please do a new PR with fixes!
Sure!