qlrd
qlrd
> > @spatcho, reviewed a little your changes and there're some broken tests: > > ```shell > > FAILED tests/printers/test_cnc.py::test_print_qr_code_with_row_cutmethod - TypeError: unsupported operand type(s) for &: 'str' and 'int'...
> > > > @spatcho, reviewed a little your changes and there're some broken tests: > > > > ```shell > > > > FAILED tests/printers/test_cnc.py::test_print_qr_code_with_row_cutmethod - TypeError: unsupported operand...
> Time to refine the PR run `poetry run poe black` to format your code changes. run `poetry run poe lint` to run pylint to check some code compliance parameters,...
Agreed, there's a lot of ways to manipulate the git history so he do not lost his work. I think with some `git add --patch`, `rebase`, `fix` and `drop`s is...
> > That works too! I still see changes in .gitignore and PR templates that needs to be undone. > > About .gitignore : I replied to qlrd comment here...
> That works too! I still see changes in .gitignore and PR templates that needs to be undone. I believe it's worth to a rebase too, see that are two...
> > > > That works too! I still see changes in .gitignore and PR templates that needs to be undone. > > > > > > > > >...
@spatcho, you work is awesome. I think you will be a great addition! I know git could be hard at first, and was for everyone on the team. I hope...
@spatcho, i think i managed to separate the CNC code. Could you review to see if i didnt forget anything? https://github.com/selfcustody/krux/compare/develop...qlrd:krux:qr_cnc?expand=1
@spatcho, can you review and test https://github.com/selfcustody/krux/pull/562 ?