Patrick Wolfert

Results 46 comments of Patrick Wolfert

Doing a little research here. It looks like this is the relevant bit of code: https://github.com/CMSgov/design-system/blob/master/packages/design-system/src/components/FormLabel/FormLabel.tsx#L139-L143 The [_hidden error_ here](https://github.com/CMSgov/design-system/blob/master/packages/design-system/src/components/FormControl/FormControl.tsx#L161-L164) is only rendered when the error is being placed below...

Moved this to the top of our backlog. We have a very long backlog, and even though a decision was made on March 18th about what needs to be done,...

Hey @anthony-kopczyk, We're in the process of swapping out the implementation of our `Dialog` component to use the [native `` element](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog). That would mean it would no longer be in...

@zarahzachz , is this ready for review?

Sorry this took so long to be picked up, @Josh68. This is now being tracked in Jira: https://jira.cms.gov/browse/WNMGDS-1669

Right now the error I'm getting on the visual regression tests is due to the fact that initial focus for dialogs is now the close button, which I'll need to...

@forrestbaer and @zarahzachz, I realized that I hadn't filled out the description of things I changed, and when I was filling it out to make our job easier at release...

Before we can consider merging this, we need to audit the design portion of these checklists and make sure this info is accurate.