design-system icon indicating copy to clipboard operation
design-system copied to clipboard
verified publisher icon CMSgov

[WNMGDS-1792] Dialog to native dialog

Open pwolfert opened this issue 3 years ago • 1 comments

Summary

https://jira.cms.gov/browse/WNMGDS-1792

How to test

  1. Use Storybook to manually test Dialog and the components that use it (IdleTimeout, and external link pattern story)

Checklist

If this is a change to code:

  • [x] Created or updated unit tests to cover the logic added
  • [x] If necessary, updated unit-test snapshots (yarn test:unit:update) and browser-test snapshots (yarn test:browser:update)

If this is a change to documentation:

  • [ ] Checked for spelling and grammatical errors

pwolfert avatar Sep 28 '22 05:09 pwolfert

Right now the error I'm getting on the visual regression tests is due to the fact that initial focus for dialogs is now the close button, which I'll need to fix before I take this PR out of draft state.

pwolfert avatar Sep 30 '22 22:09 pwolfert

Focus issue was my mistake. A11y testing completed and passed.

danbivins avatar Oct 07 '22 17:10 danbivins

Thank you, @SparrowSpit!

pwolfert avatar Oct 07 '22 17:10 pwolfert

@forrestbaer and @zarahzachz, I realized that I hadn't filled out the description of things I changed, and when I was filling it out to make our job easier at release time, I also realized that the prop types didn't include all the attributes of <dialog>, so I updated the types in https://github.com/CMSgov/design-system/pull/2175/commits/17db2d010c7fd805df0c8897dea33542f669f102

pwolfert avatar Oct 07 '22 17:10 pwolfert