design-system icon indicating copy to clipboard operation
design-system copied to clipboard
verified publisher icon CMSgov

[WNMGDS-1402] Remove unnecessary nav els

Open zarahzachz opened this issue 3 years ago • 3 comments

Summary

Jira ticket

For vertical nav: Added conditional logic to wrap link list with a <nav> only if it's not nested (using already existing nested prop).

For header: WIP

How to test

For vertical nav: Run yarn storybook locally, navigate to http://localhost:6006/?path=/story/components-vertical-nav--default-vertical-nav and open developer tools. You should only find one instance of <nav> being used.

For header: Run yarn storybook:healthcare and navigate to Header component. Note only one <nav> in use.

zarahzachz avatar May 20 '22 17:05 zarahzachz

@zarahzachz , is this ready for review?

pwolfert avatar May 26 '22 21:05 pwolfert

@zarahzachz , is this ready for review?

Not yet - I wanted to chat with a designer about this to make sure it's good.

zarahzachz avatar May 27 '22 13:05 zarahzachz

Is this ready for review now?

forrestbaer avatar Jun 24 '22 14:06 forrestbaer

@line47 or @babsdenney could you take a look at the Healthcare header part of this? I want to make sure I didn't introduce any breaking visual changes to it and so much has changed in the DS since this PR was first opened.

zarahzachz avatar Aug 23 '22 18:08 zarahzachz

@zarahzachz header looks good to me. Compared the storybook to the live GitHub doc site and looked :100:

line47 avatar Aug 23 '22 18:08 line47