Patrick Ziegler
Patrick Ziegler
Aaah, now everything makes sense. The dummy tree item is created in `updatePlus(...)`, in response to Bug [210747] > I can guess its hard to come of with a simple...
I had a closer look at Bug [210747](https://bugs.eclipse.org/bugs/show_bug.cgi?id=210747) and whatever was done with f1899ad2abb3cb64959103464c21227d59b4f994 doesn't work, regardless of my change. > Steps To Reproduce: > 1. The content provider returns...
I've adapted the check so that for the use-case described in Bug 210747, where an element was removed from the tree that hasn't been realized yet, the `updatePlus()` method is...
I'm a little bit concerned about this code block here, which is also responsible for the test failure and which was added with #810 https://github.com/eclipse-platform/eclipse.platform.ui/blob/601b0d3006dab3d8612defae3b97d3bff53debe2/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/AbstractTreeViewer.java#L2065-L2084 In short, if `setDisplayIncrementally()` is...
If there are no objections (and if the remaining checks succeed), I'll plan on merging this within the next few days.
> Make sure in view preferences there is no other files or directories (like .settings, .project etc) are shown, so both projects are shown as "empty". Yes, the resource filter...
The `TreeItem` has a local variable that keeps track of the "expanded" state. However, this variable is not used inside `getExpanded()`, which instead calls the GTK API directly. The result...
> So it looks like the patch works on Windows only? That seems to be the cases, yes. > Have you Mac access, any idea how it looks there? No,...
@iloveeclipse I've updated the commit/pr message and elaborated a little bit on what exactly is going wrong and why.
No worries. Thanks for also taking a look at this change. Otherwise I completely would've missed the weird behavior on Linux.