Patrick Ziegler

> I just wanted to note that if we talk about P2 units(!) they usually use the symbolicname = unit id, but this is not mandatory! For features they even...

> Here we add the repository URL repository_url as a known key qualifier. This would be mandatory, as we have no default. In the end, I think making the repository...

> Given that there is no central authority like maven central and we have no way to know the real origin, I would describe the uri (!) (not url as...

So to briefly summarize: The PURL should be calculated based on p2 artifacts, rather than units. This necessitates the following components: - `namespace:` the artifact id, required - `version:` the...

A proof-of-concept has recently been merged to Tycho via https://github.com/eclipse-tycho/tycho/pull/3258, based on this proposal. The only noteworthy change is that the `location` now corresponds to the base URI of the...

> ImageDescriptor.createFromFile would search relative from the provided class file. Should be maybe add a createFromBundle which allows to use the top-level directory? +1 In WindowBuilder, we already ran into...

I recently worked on a similar problem again and noticed that this functionality is already provided by the [ResourceLocator](https://github.com/eclipse-platform/eclipse.platform.ui/blob/master/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ResourceLocator.java), which provides the following methods: - `imageDescriptorFromBundle(String bundleSymbolicName, String imageFilePath)` -...

> > there is even a convenience method already: > > `org.eclipse.jface.resource.ImageDescriptor.createFromFile(Class, String)` > > Actually there is already such method as it was mentioned above. Those methods are not...

> have you tried ImageDescriptor.createFromFile(IDE.class, "/icons/full/obj16/error_tsk.png"); just currious Color me impressed. I didn't expect it to work, so I take back my previous comment.  In that case, the use...

That's my take on the animation issue, I suppose. I've tested this fix against https://bugs.eclipse.org/bugs/show_bug.cgi?id=137786#c23 and while I can reproduce those artifacts with `canvas.update()`, I can't with this fix. Do...