Patrick Ziegler

@azoitl There are currently three potential fixes for the animation bug. - https://github.com/eclipse/gef-classic/pull/377, which only fixes the animation but nothing else. - https://github.com/eclipse/gef-classic/pull/378, which fixes it in general, but -as...

From my perspective, a repaint _has_ to be done, in order to satisfy the contract of `LayoutManager.performUpdate()`. Alternatively, we can always go with the solution proposed by Phillipus (PR 377),...

The underlying problem is that the entire animation is done inside the UI thread. So any intermediate paint operations can't be done unless explicitly invoked. Previously, this was done implicitly...

@azoitl ~~Speaking about performance: At least on Linux, my solution seems to be slower. When you try it out with the ZoomSnippet, you have a 4-5 seconds warmup time where...

I've cherry-picked https://github.com/eclipse/gef-classic/pull/377 and added it on top of https://github.com/eclipse/gef-classic/pull/446. This error should not happen: ``` 2024-05-22T16:20:35.5200700Z org.eclipse.zest.tests.examples.GraphSWTTests.testZoomSnippet -- Time elapsed: 0.119 s

> This takes about 4s. removing this 4s with the PR our editors are opening around 25% slower. Out of curiosity, how long does it take with the "original" implementation?...

Hm... I'm a little curious about the test failures. I'll run some tests to see whether this is because of this PR or if they are generally not 100% stable.

Too late for the 3.20, but I would've considered it too risky, anyway.

Can you perhaps post a screenshot of what you mean? I've reverted the change locally, but I couldn't see any differences. Though that might partially be due to me using...

Ah, so that's what you mean. Thanks for the example! Hm, it doesn't look like those animations are played at all on Linux, regardless of whether the update method is...