Piotr Smaron
Piotr Smaron
@cvybhu is looking into it
> > > > Please adjust the TODO list at least. > > > > > > > > > I will > > > > What does the lack...
> @ptrsmrn who do we have who's familiar with service levels and can look at this? @nyh I think @Jadw1 would be the person.
Version 3: - made the change compile'able and I'll try to keep it that way - had to rebase on top of master, which was painful due to topology builder(s)...
Version 4: 1. Rebased on top of `master`, which eliminated my commit refactoring topology_builder to a separate fail thanks to https://github.com/scylladb/scylladb/pull/16609/files + I got `tablets.transition` thanks to https://github.com/scylladb/scylladb/pull/16894/files 2. Added...
Version 5: 1. [resolve minor comments](https://github.com/scylladb/scylladb/pull/16723/commits/48c4932deccc2f5c2c043566a8061e687ea47c9b) - mostly cleaned the code a bit 2. [save rf change data as a topology mutation](https://github.com/scylladb/scylladb/pull/16723/commits/297b552c5ca1042cf2fbce69396b20dc2b12d0f8) 4. [add tablets migrations to topology coordinator](https://github.com/scylladb/scylladb/pull/16723/commits/95b77d4f2403f2846b37f4b58973a12992aa661f)
Version 6: - Trying to compile, but hit `qp` vs `ss` init problems, see https://github.com/scylladb/scylladb/pull/16723/files#diff-bf1eacd22947b4daf9f4c2639427b8593d489f093eb1acfbba3e4cc1c9b0288bR1420 - of course simple reordering doesn't solve the issue - minor fixes - rebased with...
CC @tgrabiec Version 7: 1. (there is some extra debug code that prints additional stuff, I'll remove it later). 2. the code compiles and runs, migrations seem to be constructed...
My guess is that [waiting for topology request completion](https://github.com/scylladb/scylladb/pull/16723/files#diff-a53975e8249bad5bbc4a5d7716048d95dc51a038f35d58252d87a3c1a276f155R5587) doesn't work, because this function doesn't handle global requests.
Version 8: - adding/removing tablets replicas doesn't really work, and it's mocked in a way that works when creating a ks with rf=1 and altering it to have a ks...