Piotr Smaron

Here're the logs for the [leader](https://jenkins.scylladb.com/job/scylla-master/job/scylla-ci/12456/artifact/testlog/x86_64/debug/failed_test/test_alter_tablets_keyspace_concurrent_modification.3.debug.3/scylla-25.log), and the [follower](https://jenkins.scylladb.com/job/scylla-master/job/scylla-ci/12456/artifact/testlog/x86_64/debug/failed_test/test_alter_tablets_keyspace_concurrent_modification.3.debug.3/scylla-29.log). The sequence of actions is (note the timestamps): 1. the leader is about to submit ALTER and waits: ``` INFO 2024-10-16...

I wonder if this testcase is even needed. I mean, the retry on concurrent modification was implemented incorrectly for ALTER tablets KS, which has been fixed in this PR. I...

> > and eventually it succeeds, but it's too late > > Actually schema agreement wait doesn't succeed -- the driver is timing out after 20 seconds. Schema agreement doesn't...

The CI is green. I believe the latest fix addressed the flaky test.

@nuivall can you please review?

@nuivall @kbr-scylla This item is a 2024.2 release blocker and I'm going on vacation starting Thursday (Thursday included), so we have ~1 day before my leave to merge it, otherwise...

@kbr-scylla @nuivall all comments resolved, the CI is green

> I have some issue reference nitpicks. > > Also, please consider also doing #18876 - you need to also mention counters as not being supported on the CREATE TABLE...

@kbr-scylla `test/topology_experimental_raft/test_fencing.py::test_fence_writes` [fails](https://jenkins.scylladb.com/job/scylla-master/job/scylla-ci/10074/testReport/(root)/test_fencing/Tests___Unit_Tests___test_fence_writes_debug_1/) (as expected) on: ``` > table2 = await random_tables.add_table(name='t2', pks=1, columns=[ Column("pk", IntType), Column('counter_c', CounterType) ]) ``` when I disable creating tablets tables with counter columns (this...

CI failed on a flaky dtest, the Issue against this failure has been already opened, I linked this failure to that ticket - https://github.com/scylladb/scylladb/issues/19620#issuecomment-2209489290 @nyh can you re-review please?