Nicholas Hastings

Results 106 comments of Nicholas Hastings

That's indeed confusing, but I'll have to try it out. The main ABI points should be the virtual functions and the class members, all which do all use int64 for...

It still crashed for me after updating those. I did look further into the actual crash however, and it's in CCvar::RemoveSplitScreenConVars, suggesting that there still is an issue with flags...

I updated the flags var in all usages I could find in the latest commit. As a sanity check, could you compare to your files to see if I missed...

Ah ha! Thank you. That makes sense and does explain the crash perfectly. I can confirm the other issue now as well and will look into that.

I'm not sure yet. It's possible that in Source 2, some additional function from server.dll/so gets called after IAppSystem::Shutdown.

I'm probably about to give up on this for the day, but the issue does seem like it could still be related to ConVars. On Windows (using the win32 build),...

I realized that in one of the plugins I had loaded, there was a global ConVar change callback installed (and maybe you do too?). If I remove that, it's back...

With the global change callback disabled, do you still get a crash in vstdlib at shutdown? (Presumably the same CCvar::RemoveSplitScreenConVars crash I see)

Not really, sorry. Got sidetracked with other things. I'll try to get back to it later this week.