Patrick Venture
Patrick Venture
Updated free calls, but, in this file, there is a lot of style work required to bring it up to snuff. I'd like to save that for another PR set...
Alexander, this one is likely ready for review. There is some whitespace cleanup, I'm going to try and verify it's associated with a commit editing those lines, and when not,...
I'm cleaning up the patches to remove any formatting outside the exact lines involved. And then, I"m going to tack on a few extra patches that do things like fix...
Code is ready for review, thanks.
Ok, weirdly, my stack of patches doesn't match that order. and when I force push it, it isn't fixing it...
Looks like it's happy, maybe the order doesn't match the reality. I see the SHAs match mine. Please take a look, this should be ready.
It's saying the label "out" isn't used, but it is, as that function has ERR_OUT and is part of the same patch that changed that method.
Alexander, unless I'm mis-reading the code, the bug is in the Codacy/PR Quality Review - that it's not parsing what the macro does.
Like the other PRs, I'm updating them today to split out the changes more cleanly, and also to remove places where I deleted code that is specified as "should be...