Patrick Venture
Patrick Venture
Updated static returns -- there are some other bits where the code could be improved by using helper methods -- will evaluate on demand.
Fixed static method definitions impacted by this PR.
I don't have an nm enabled system. I checked this morning and none of the commands returned anything but 0xc1.
> > I don't have an nm enabled system. I checked this morning and none of the commands returned anything but 0xc1. > > Well, that's expected for non-nm systems....
Alexander, PTAL - I rebased these patches onto a style commit to remove the style changes from each patch.
Updated free() calls, and other related buffer cleanup.
Two methods moved are now ranked complex. Alexander, thoughts on this? I was hoping to avoid re-working the Dell SEL code in this PR. Even though, it definitely needs some...
I'm going to split up the functions, I read through the dell one, and it's pretty straightforward in its goal, and looks easy to split via helper methods to handle...
I applied a general style fix commit, then the change, then the IS_SET change.
I don't see a button to indicate, "PTAL again, things should be fixed"