[WIP] cleanup: sdr

Open pstrinkle opened this issue 7 years ago • 2 comments

Remove assignments with no effect: [lib/ipmi_sdr.c:3190]: [lib/ipmi_sdr.c:3242]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?

Also fixup the assignment to e within the for loop, as the iterative step is immediately overwriting this assignment with f.

Signed-off-by: Patrick Venture [email protected]

Nov 26 '18 21:11 pstrinkle

Like the other PRs, I'm updating them today to split out the changes more cleanly, and also to remove places where I deleted code that is specified as "should be there."

Nov 29 '18 19:11 pstrinkle

Updated static returns -- there are some other bits where the code could be improved by using helper methods -- will evaluate on demand.

Dec 10 '18 18:12 pstrinkle