Johan Euphrosine

Results 579 comments of Johan Euphrosine

@hung-chi thanks for working on this! Do you think it would it makes sense to modify the notebook so that they can be opened in https://colab.research.google.com/ ? If you agree,...

@siddharth-joshi thanks for the find! I'll try to switch my notebook to that https://colab.research.google.com/gist/proppy/00b7a5e58314a9d387e8174581c77866/skywater-pdk-sky130-raw-data.ipynb, that'll be way more reliable than the current fragile regexps.

@siddharth-joshi I gave it a try in https://github.com/google/skywater-pdk-sky130-raw-data/pull/7

> I think DMT is GPL, you may wish to double check you can actually use it. Ah yes, you're right I should update the copyright notice of the combined...

@miesli thanks for raising this, let's continue the discussion about the naming scheme in https://github.com/google/skywater-pdk-sky130-raw-data/issues/9#issue-1325945012.

> Furthermore, I generated an example to read in the full data set you provided in https://dmt.semimod.de/examples/readin_dut_lib.html > To show off some off the possibilities, here is the generated documentation...

@mkkassem @atorkmabrains I think you can easily create a separate pull request for the models changes this way: ``` # clone upstream repo git clone https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr cd globalfoundries-pdk-libs-gf180mcu_fd_pr # add...

@atorkmabrains I'm confused, I don't think the README changes to the `models/` directory that we're discussing here are related to the cell renaming changes? So they should be PR-able and...

> Even if we only take readme changes, if you use it as is it will be broken. The renaming changes don't seems to affect the models, ex: https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/pull/48/files, so...

What's important for those change is that we're able to run the tests for a given PR, so you need to merge the test either before (or with) the rename.