Johan Euphrosine
Johan Euphrosine
Basically if you: 1. take the instruction in https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/issues/69#issuecomment-1311157859 2. force push to https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/pull/33 branches (https://github.com/mabrains/globalfoundries-pdk-libs-gf180mcu_fd_pr/tree/primitives_names_part2) 3. mark it as fixing this issue That should be enough to provide a...
@atorkmabrains, yes but that particular PR (#33) should be revieweable/mergeable independently of the remaining 17 as long we integrate it with the rest of the `models` change as shown in...
Thanks for adding those! @RTimothyEdwards is there any regression testing in place in open_pdks for those rules that we can import, or should we log an issue to create a...
@RTimothyEdwards Thanks for the explanation. @atorkmabrains would it makes sense to update the pcells to always draw `LVPWELL` when `Bulk Tie` is set? https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/11770e5e5bae2a2072899e7ef282c080e6c5d762/cells/klayout/pymacros/cells/draw_mos.py#L192-L195
@atorkmabrains currently it seems that `LVPWELL` is only drawn when `DNWELL` is set in the pcell option, would it make sense to update the pcell implementation to always draw `LVPWELL`...
My understanding is that in https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/issues/104#issuecomment-1421127633 @RTimothyEdwards stated that `LVPWELL` without `DNWELL` was a valid usecase. Shouldn't we make sure that this is also supported by the pcell?
@atorkmabrains I think this is due to the substrate connection of the bulk tie creating an additional signal (`gf180mcu_gnd`) when the `LVPWELL` is not present. Is there a usecase for...
> bulk tie doesn't need LVPWELL to happen, please read here: https://en.wikipedia.org/wiki/CMOS Thanks for providing the links, I could find any mention of `bulk tie` nor its relation (if any)...
@mkkassem @atorkmabrains I think you can easily create a separate pull request for the pcell changes this way: ``` # clone upstream repo git clone https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr cd globalfoundries-pdk-libs-gf180mcu_fd_pr # add...