Pavlos Rontidis

Results 222 comments of Pavlos Rontidis

Hi @jorgehermo9, I am looking at this now. Two quick things that popped out: * The spell checker is failing * You can add a new scope in `.github/workflows/semantic.yml`

This 99% ready to go. We will need some more docs. See [this comment](https://github.com/vectordotdev/vector/pull/22072#issuecomment-2576203234) from another PR.

> Can't update license files because of > > ``` > > cargo vdev build licenses > Error: Could not read "/home/jorge/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/allocator-api2-0.2.16/license" > > Caused by: > Is a directory...

> cargo vdev build licenses You can try ` cargo vdev check licenses` and also we have the CI

Exciting, thank you @jorgehermo9 🎉

> @jszwedko @neuronull I updated the PR and applied fixes according to comments and currently waiting for another round of review 🙏 Hi @nabokihms, thank you! I will review this...

Spell checker failed: https://github.com/vectordotdev/vector/actions/runs/11721969450/job/32650529849?pr=17389

> @pront I tried to fix the error but probably made it worth... Could you please guide me what is the issue? It seems like it is not in my...

@nabokihms can you apply this https://github.com/deckhouse/3p-vector/pull/447? Or you can manually do: 1. git revert https://github.com/vectordotdev/vector/pull/17389/commits/90de69be7162e4ec2867b889a2ffd6ed0df457bb 2. `git merge origin master`

Sorry for the friction here, but this conflicts with the spell checker fix on master. Please revert the changes to: * .github/workflows/spelling.yml * .github/actions/spelling/expect.txt You can just `git checkout origin/master...