Pavlos Rontidis
Pavlos Rontidis
> @pront does having `cookie_name: String::new()` at [#23156 (files)](https://github.com/vectordotdev/vector/pull/23156/files#diff-e552ee7226373645b14f33a1cdfdd67eba694938b3f265ac2ac3105d37c75b5fR72) not make it optional? Hello, see this example: https://github.com/vectordotdev/vector/blob/master/src/sources/host_metrics/mod.rs#L117-L120 That's what I was thinking about. > I did run the integration...
Hi @saeedek, small request, please don't force push to help us with the review. You can push as many commits as you want. We eventually squash them.
Hi all, thanks for this contribution! FYI I see a conflict and a failing CI check.
We are reviewing https://github.com/vectordotdev/vector/pull/23422. It should be part of the next Vector release.
> > I also need templating in the `uri` field for my use-case. > > [@pront](https://github.com/pront) Im guessing this requirement would need to fall into a separate issue / work...
There are a few failing checks. Also, let's add a new `postgres` semantic scope in https://github.com/vectordotdev/vector/blob/master/.github/workflows/semantic.yml. I will review once these are addressed. Thank you!
> Hi @pront. I'm sorry for the delay. I added a bunch of new integration tests and I'm ready for another review round. > > I still have a few...
Just dropping by to say that I am looking forward to introducing this new integration in Vector. And don't hesitate to give me a shout if you need anything.
Of course! No need to apologize at all 😅 I just wanted to express my excitement about this work and to let you know I’m here to support whenever you’re...
> Hi @pront, I have more time available these days and will work in this PR. I have left to test how this sink behaves with metrics and traces and...