Pavlos Rontidis
Pavlos Rontidis
Hey, I did a quick pass as promised. A general comment here is that the proposed change semantically is more like a "global VRL state" vs a "VRL cache". @fuchsnj...
> Does adding some kind of global state to VRL (optional, it would have no effect unless user specifically calls these functions) make sense for you? Does it break any...
Ideally we would build on enrichment tables which is currently used as external state for VRL. Looping in cc @lukesteensen for future discussions.
> I have prepared the implementation of StreamSink trait for this component, but I am not sure what would be the best way to connect it in as a sink....
@esensar let me know if you are blocked on this
Awesome. 😅 Apologies for the confusion, I commented before I refreshed the page so I didn't see the new activity in this PR.
Disclaimer: Bear with me as I ramp up in this area. Would this be considered a breaking change? Per https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/ I think this can change pod grouping.
Hi @Serendo, thank you for this PR! I think this is not a breaking change (from the perspective of Vector users). And also we will need a changelog to explain...
> Hey @pront . What's still needed here to get this one across the line? Would be great to see it in the next release. Hi @Serendo and @tronboto, I...
Will review again once the merge conflicts are resolved.