Pavlos Rontidis
Pavlos Rontidis
Hi @Serendo and @adezxc, I was away for a couple of weeks. This is PR is non-trivial to review as is but we are motivated to review it carefully, @bruceg...
> > Hi @Serendo and @adezxc, I was away for a couple of weeks. This is PR is non-trivial to review as is but we are motivated to review it...
Hi @Serendo, to help us review this, let me know the following please: 1. after the rebase, are the old review comments still relevant? were they all addressed? 2. update...
There a few open comments, will come back to this when I see new commits.
Please take a look at the merge conflicts. We will take a look after those are fixed.
Hi @bingquanzhao, thank you for this PR. Please rebase on master and fix merge conflicts. There are 12k affected lines right now.
Please merge / resolve conflicts with `origin/master`. The new `make fmt` should also update the formatting. In the meantime, we will review this PR soon.
Hello, I will review this tomorrow but due to the PR size, it's unlikely that we can merge it before the merge window closes.
> > Hello, I will review this tomorrow but due to the PR size, it's unlikely that we can merge it before the merge window closes. > > Thanks. What...
Hi @jvperrin, sorry for the delay on this one. Our Splunk IT suite needs some attention (https://github.com/vectordotdev/vector/issues/22379). One thing that stood out is that this new cookie is mandatory which...