Paul R. C. Kent

Results 354 comments of Paul R. C. Kent

SInce 2.2.3 failed, trying 2.2.2 since that is what is in the nightlies.

Update: Not yet successful in reproducing. mac + close approximation to versions in CI installed via brew gave a passing test.

Tried rerunning. Still broken. There is clearly a mac specific difference to solve ``` 735/1011 Test #1882: ntest_nexus_structure .............................................................................***Failed 0.82 sec Test name : structure Test sublabel : test_min_image_distances Test...

Seeing if 2.3.0 &/or if any of a @Kcorbyerd 's fixes might have improved this as a side effect.

=> ntest_nexus_structure still breaks on macos with homebrew deps & numpy 2.3.0 vs 1.26.4

Many thanks for identifying the culprits on this many months old problem. As we discussed yesterday there are two issues: First, the behavior of numpy is not exactly the same...

Thanks for the full fix, Brock. FYI, someone else will need to review + approve before merge since this is built on my original PR.

Edit to add: Clearly the answer is "yes", but whether we should is a more important question. === Original: I agree that the input is not ideal. Possibly the manual...

[ For those not familiar, DRY = Don't Repeat Yourself ] Agree we should avoid repeating this code.