Paul R. C. Kent
Paul R. C. Kent
@ye-luo Can you please take a look at this? I wonder how this is logically possible. Perhaps we have a
Good point. Can you write down an algorithm for your preferred ordering? e.g. Put anything matching some wildcard first, another wildcard second.
This is an interesting observation and good to note. Presumably no one has hit it in practice otherwise they would have commented, so it is happily not a major blocker....
Suggesting a fast route to get this merged: 1. I think you only need to update the gold files to get the converter tests passing -- QMC runs are not...
Test this please
FYI, the more modern compilers are complaining e.g. ``` src/QMCHamiltonians/tests/test_SOECPotential.cpp:258:54: error: non-const lvalue reference to type 'Real' (aka 'float') cannot bind to a value of unrelated type 'Return_t' (aka 'double')...
A huge improvement and good to get in. Need to identify what is needed for batched code execution in followup work.
(Hadn't noticed the "Unchanged files with check annotations" beta feature before. Would be good to work the matrix of options in subsequent PRs to get coverage on these features since...
> Where is this feature? Click your "More static member functions." commit and scroll down.