qmcpack icon indicating copy to clipboard operation
qmcpack copied to clipboard

create_names for timers violates DRY and has scoping issues.

Open PDoakORNL opened this issue 10 months ago • 1 comments

In the course of using detailed timers with TimerManager, there is repeated code used to connect time id enums and string labels. This can likely be deduplicated, also the labels and enums don't need to be in global scope and should follow the current code standards. (see WalkerLogBuffer..h:130) for fix to scoping.

Since this is a facility that is fairly new and will be added to new performance critical code it would be good if the few places it is currently used it illustrated best practice.

PDoakORNL avatar Feb 10 '25 18:02 PDoakORNL

[ For those not familiar, DRY = Don't Repeat Yourself ]

Agree we should avoid repeating this code.

prckent avatar Feb 14 '25 22:02 prckent