Jarek Potiuk

Results 1573 comments of Jarek Potiuk

@dirrao - are you continuing with that :) ?

I think it would be a great idea to review and make it "common" and reused accross the components. Also we have another, related discussion about logging in https://github.com/apache/airflow/issues/45079 where...

> I might start by breaking down https://github.com/apache/airflow/issues/45079 into some TODO tasks and proposing PRs. Do we need to collaborate on Slack, or is discussing on GitHub sufficient? GitHub is...

Yeah. Fixed in main (including #45131 fixing selective checks that caused broken main). Rebased it now.

> It seems there are might be some pr's until now went out without providers tests. and good thing we have schedule run to spot out these like the one...

> I guess this also applies to the already existing Principal and Proxy User fields? I see that they only validate if a ; character was passed I think there...

Just one comment here -> I've heard (but it's mostly through grapevine) that for quite a long time, uvicorn has the capability (and it's more and more recommended in production)...

Just adding a unit test, and I think it's ready to go :)

> I see some discussions around, does anyone have any suggestions for this? I use Pycharm I believe (I have not yet had time to look at it) this requires...