airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Refactor Azure Service Bus: move create_subscription to hook

Open perry2of5 opened this issue 1 year ago • 2 comments

This commit refactors the logic to create a subscription into the hook. The operators should not be accessing the connection to Azure Service Bus directly. This code belongs in the hook to promote reuse.

In addition, it allows the caller to pass a RuleFilter to apply to the subscription to limit which messages are sent to the subscription.

@dabla: this addresses part of your comments on PR 44675

perry2of5 avatar Dec 20 '24 21:12 perry2of5

The build failure appears unrelated to my re-wording of the comment :)

perry2of5 avatar Dec 21 '24 01:12 perry2of5

Yeah. Fixed in main (including #45131 fixing selective checks that caused broken main). Rebased it now.

potiuk avatar Dec 21 '24 08:12 potiuk

Thank you to both of you!

perry2of5 avatar Dec 22 '24 04:12 perry2of5

Thank you to both of you!

Nicely done, good work!

dabla avatar Dec 22 '24 07:12 dabla