Eduardo San Martin Morote

icon indicating a website link https://esm.dev

icon company Freelance icon location Paris icon location Member of the @vuejs core team Speaker, trainer. From 🇪🇸, lives in 🇫🇷

Results 866 comments of Eduardo San Martin Morote

Warning of invalid param for catch all route with named route redirect

Sure

Warning of invalid param for catch all route with named route redirect

It's the very first comment, I added some extra examples: https://github.com/vuejs/router/issues/1617#issuecomment-1320941431

Corrupted GIF header causes null pointer dereference by failed allocation due to integer overflow

Seems to be in the external lib. Feel free to try to fix

SSR fails to render component inside v-else of a v-if with v-html

A workaround is using a `template` tag: ```vue bar: ``` For SSR repros, it's usually easier to do them with the bare minimum. Here is an example: ```js const Vue...

Style binding: implicitly assign 'px' as the default unit for numeric values for certain css properties

I'm not a fan of this either, it means we have to keep another list of [unitless properties](https://github.com/facebook/react/blob/4131af3e4bf52f3a003537ec95a1655147c81270/src/renderers/dom/shared/CSSProperty.js#L15-L59) and keep it up to date, and it has to be added...

Style binding: implicitly assign 'px' as the default unit for numeric values for certain css properties

Unfortunately, that wouldn't be consistent and confusing to users

feat(props): allow defining a required prop as null

Added some tests to reflect that as well

Provide/inject for custom directives

Can you please be more explicit about what kind of directive would need that, please? A configuration could be extracted into one single js file and import it in different...

Provide/inject for custom directives

I really think directives are probably not what you want to use for CSS in js. To me, your example looks perfectly fine using the config + primaryColor. Yes, it...

Provide/inject for custom directives

> Yes, I agree, this is a downside, but you could say the same for provide/inject functionality in components and that is already in Vue. You could also say the...