Eduardo San Martin Morote

icon indicating a website link https://esm.dev

icon company Freelance icon location Paris icon location Member of the @vuejs core team Speaker, trainer. From 🇪🇸, lives in 🇫🇷

Results 866 comments of Eduardo San Martin Morote

Router creation performance degradation when using many routes in comparison to v3

Using radix3 for a custom matcher would be nice. Note it doesn't cover all features (it can't as a trie). It's really great to see that there is no performance...

docs(fa): start Persian docs

Thanks a lot! I’m still not sure if we want to merge all doc translations here. I will come back to this in January/february. In the meantime, we could just...

beforeEach guard not changing URL after user uses back button

You are being redirected to the Home page because that’s what you return in the navigation guard

beforeEach guard not changing URL after user uses back button

I opened https://github.com/vuejs/router/pull/2133 with a workaround.

Allow passing transient `info` in navigations

This is what we call transient state (state available only during navigation) and is planned in a way that would align with the upcoming navigation API (https://github.com/WICG/navigation-api#example-using-info). It would require...

View Component unnecessarily updates when child route changes

did you try moving the `onVnodeUnmounted()` outside of the render function to fix the problem? Maybe it just needs that

View Component unnecessarily updates when child route changes

It's true having the closure avoided timing issues. Having a watcher didn't cover all cases if I remember well but I think I added tests so they should fail if...

View Component unnecessarily updates when child route changes

I think I found a way of fixing this. It still rerenders when using a `` component but it looks like a Vue behavior. I need to check that further.

slashes should not be encoded for catch all regexes

This behavior is intended for regular params like `:param` because the `/` is a delimiter of params, but it should probably not happen for star params (`:param(.*)`) Note to myself...

Warning of invalid param for catch all route with named route redirect

This is due to the implicit parameter being passed during a redirection. You can workaround it by passing an empty object of Params alongside the name of the route: `redirect:...