Eduardo San Martin Morote comments

Results 866 comments of


                                            Eduardo San Martin Morote

fix(peer-deps): re-declaring peer-dependency of vue-demi

> It is customary to re-export the peer-dependencies of your dependencies That seems counterintuitive. Do you have a source? Is this yarn only? If a package dependency's peer dependencies are...

fix(peer-deps): re-declaring peer-dependency of vue-demi

Thanks for the contribution, I found out this could break usage for existing users and creating really hard to debug errors. Usually one installs this package after installing vue and...

[Feature Request] Use the new browser Navigation API to show a native loading indicator when navigating

I have more detailed answers in the Vue router repo and the summary of it is that the navigation API is still experimental and could change or disappear at any...

`watchEffect` within `effectScope` is removed when component is unmounted

But the watchEffect should be attached to the effectScope like a regular watch The return is intentional to simulate a store

Refactoring options api to use vue-router/composables break basic unit tests

Any mock to the router does indeed need a bit more if they use the composables. I think some cookbook entry would be a nice thing if anybody is up...

backport navigation guard return values

Some features cannot be backported without rewriting big parts of the router. I tried porting back as much as I could in the limited time I have. If anybody wants...

Update location.js

Closing due to inactivity. Please open a new issue with a reference to this one if you can follow up with more information.

TS throwing "missing param for named route..." when param is empty string and runtime error when is empty string

v3 is a bit stricter here but it could indeed handle it if the runtime already works. As a workaround, you can can try to omit the param: ```ts params:...

fix(history): Resolve the href in `<base>` correctly (#3819)

Thanks for the PR. Can you provide a failing test or boiled-down repro? Note a base should not contain a hash

fix(history): Resolve the href in `<base>` correctly (#3819)

That base has a hash though. As I said, it cannot have a hash