Eduardo San Martin Morote comments

Results 866 comments of


                                            Eduardo San Martin Morote

Changed behaviour for optional params

I added a test but that seems to be working. If that's not what you meant a boiled down reproduction or a failing test would help. I updated the docs...

Changed behaviour for optional params

Ah I see, the behavior should be consistent: - `router.push({ name: 'optional', params: { p: null }})` - `router.push({ params: { p: null }})` No matter the current location. The...

test: earlier routes should have matching priority

> I'm not clear whether this is documented anywhere, but I think it's a reasonable assumption and something that people are likely to be relying upon, even though they may...

fix: avoid normalizing the fullPath

Thanks for the info, if you create a boiled down repro without external deps that would be really helpful

fix: avoid normalizing the fullPath

Yes, a reproduction without i18n and Nuxt would help. The repro with i18n still looks like a black box without any errors so I can't know what is happening

fix: avoid normalizing the fullPath

I reverted this and released a new patch

hash decode not match the later encode

The inconsistency in `route.fullPath` is a bit inconvenient but as long as the `route.hash` (and the other properties) is consistent, it's okay. In future major versions it will be possible...

hash decode not match the later encode

I had to revert this because it breaks other behaviors... This will be a wontfix until we use URL

Router creation performance degradation when using many routes in comparison to v3

Thanks for the investigation. It would be interesting to see an actual perf benchmark (without nuxt). The difference in creation shouldn't be that big. That said, Vue Router 3 had...

Router creation performance degradation when using many routes in comparison to v3

I checked on https://lahmatiy.github.io/cpupro/ with the cpuprofile file and the insertMatcher is what takes the most time! Feel free to give the topic some thought and try to raise a...