Patrick Ohly

Results 1006 comments of Patrick Ohly

Is only Kubernetes using the context feature in Ginkgo? All other projects using it will have the same challenges.

@thediveo: ` Eventually(ctx, func(...))` also works. I find that more readable than `Eventually(func(...)).WithContext(ctx)`. Doesn't make the linter's job any easier, of course :cry:

I was about to file an issue about this when I found that there is already one (okay, two...). This misuse of an assertion inside a `gomega.Eventually` and `gomega.Consistently` is...

> Global Expects within async gomega methods, are often done intentionally, in order to bail out in case of unrecoverable failures. But that doesn't work, does it? The async Gomega...

If a linter check can be implemented, then it could be kept disabled by default. If enabled, it becomes a per-project policy that global asserts should be avoided due to...

You probably know best how to do this :sweat_smile: If you don't get to it, then please ping the issue again and I'll check whether I can make some time...

@onsi: I agree with your assessment. Let's wait with the configuration option because even if it existed, I would have the problem that I can't be sure whether it is...

I haven't looked at your implementation, but it sounds like you aren't using the [facts](https://pkg.go.dev/golang.org/x/tools/go/analysis/internal/facts) API, are you? My (naive) expectation is that using facts it should be possible to...

> BTW, finding function that calls ginkgo.Fail is very hard True, it's very indirect when Gomega gets involved. Using `gomega.Expect` as an approximation and perhaps some a configuration mechanism for...