Patrick Ohly

Results 1006 comments of Patrick Ohly

I'm running this against my company's Snyk installation, not the public Snyk server.

`go vet` handles wrappers around fmt.Printf and fmt.Print by detecting calls inside wrappers: https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/printf#hdr-Analyzer_printf Perhaps something similar can be done here? Alternatively, support special comment tags?

> Hi, did you mean [loggercheck](https://github.com/timonwong/loggercheck)? No, https://github.com/kubernetes-sigs/logtools/tree/main/logcheck. Some of its functionality is specific to the [migration to structured, contextual logging](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md#name-arguments) in Kubernetes, therefore I have not tried to make...

> I'll take a look at go vet's implementation It's here: https://cs.opensource.google/go/x/tools/+/refs/tags/v0.14.0:go/analysis/passes/printf/printf.go > We could also implement it as a list of custom functions in the linter config, like I...

Another example where I would like to use it: ``` func HandleErrorWithContext(ctx context.Context, err error, msg string, keysAndValues ...any) {... } ```

klog can be used as wrapper around slog - it's a bit more flexible than that, though. But the net effect is the same: the same rules as for slog...

@tmzane: gentle ping regarding this... it would be great to get this working because in Kubernetes we start to have more APIs which accept log parameters and currently have no...

Is my understanding correct that this change will be usable right after merging, i.e. without a formal kind release?

We do a lot of runtime skipping. I think that explains it.

I'm not sure about the exact pattern, but I think Spyglass and testgrid read all junit*.xml files in the artifacts directory. You should be able to write one file per...