Lennart Poettering
Lennart Poettering
looks ok to me, just some minor points...
So this PR currently doesn't port anything over to the new interface. Can you maybe add that? We should generally have at least one user of the stuff we have...
As we do not possess a device like this this is not really actionable for us. Happy to take a patch that addresses this issue though.
hmm, i wonder if it wouldn't be better to suffix the truncated lines with something to tell the user about this. possibly a pretty unicode char of some form via...
And to me this doesn't sound like something we should add a short switch for, it's not a thing one would do all the time? or would one? dunno, if...
@tomty89 still interested in this? If so, please rework with some backwar knob logic. Otherwise we can close this?
Dropping from milestone, since it's not clear whether there's actually any bug here. @cdoern, can you retry with 251?
This is sysv compat code. We do not extend on it, as that syntax is defined and "owned" by sysvinit. We are happy to catch up with sysvinit here, but...
See #17108 for a similar case. There submitter actually fixed sysvinit first.
Well, it's not total legacy code, not code that was obsolete. just code where we reimplement an interface from sysvinit in a very close way, and where we follow what...