Lennart Poettering comments

Results 1507 comments of


                                            Lennart Poettering

cryptsetup: improve password prompt text

looks good, just some nitpicking

cryptsetup: improve password prompt text

thanks! lgtm!

RFE: allow service credentials to be updated during service runtime

credentials are immutable: once loaded the remain entirely static until the service goes down. This is explicitly documented and by design. Changing this comes with all kinds of issue, i.e....

systemctl: print better message if default target is masked

@yuwata's point was not addressed?

systemctl: print better message if default target is masked

other than that looks good now.

systemctl: print better message if default target is masked

ping?

credential passwd.plaintext-password.root too long for qemu fw_cfg

Christ, 55 chars? wtf... I guess yeah, we should advocate SMBIOS stuff more.

credential passwd.plaintext-password.root too long for qemu fw_cfg

fw_cfg is one way to propagate creds into a system. we now support smbios, sd-stub ESP pickup, kernel cmdline, fw_cfg, nspawn creds passing at least. Given that fw_cfg is one...

basic: Add log context

Hmpf. I really dislike using TLS for things like this. TLS is costly, in particular if you stick an array in it, and releasing it is cumbersome. I mean, i...

basic: Add log context

i'd be more OK with using TLS if we only store the anchor of such a linked list in it... i.e. singular fields that require no cleanup should be ok.