libplanet

libplanet copied to clipboard

Remove Sonar Analyzer suppressions

15

We need to remove [Sonar Analyzer](https://github.com/SonarSource/sonar-dotnet) suppressions. - [x] S927: Rename parameter 'A' to 'B' to match the interface declaration. - [x] S1066: Merge this if statement with the enclosing...

earlbread

`IStore.IncreaseTxNonce()` disallows the nonce to be less than zero

2

For example, the following code shouldn't be succeeded or make any updates on the store, but throw any exception instead: ```csharp IStore store = ...; Guid chainId = ...; Address...

dahlia

Prevent passing not-fully-instantiated `BlockChain<T>` to `IBlockPolicy<T>`

3

Currently, `IBlockChain.GetNextBlockDifficulty()` takes a `BlockChain` object that is not fully instantiated when creating `BlockChain` from scratch, i.e. empty. Since API specification of `BlockChain` cannot be reliable while under instantiation, this...

greymistcube

Utilize `IKeyValueStore.Get(IEnumerable<KeyBytes>)` for loading fragmented states

1

dahlia

Use vanilla `NetMQ` package instead

1

With a recent series of PR's addressing #1722, dependency on [Planetarium/NetMQ]'s custom API's have been removed. Perhaps it might be better to switch back to [ZeroMQ/NetMQ]? Simply changing the package...

greymistcube

Fix `TrieStateStore.PruneStates()` to work together with fragmented states

1

Since fragmented states were introduced: - - - - - - `TrieStateStore.PruneStates()` method has not worked well. Note that there's even a comment addressing this: There are two problems: -...

dahlia

`NetMQTransport` queue clogging due to insufficient number of workers

1

As an `ITransport` `interface`, call to each of its method with `timeout` specified should be expected fail after the given amount of time period. However, due to its internal implementation,...

greymistcube

Stack overflow while finding branchpoint

2

When trying to find branchpoint attached chain, stack flow occurs. [chain-fork-stack-overflow.zip](https://github.com/planetarium/libplanet/files/7800892/chain-fork-stack-overflow.zip) Environment: Windows10 x64

limebell

Evict dead `BoundPeer`s from `RoutingTable`

1

There seems to be some evidence that `RoutingTable`, or rather, `KademliaProtocol` to be more precise, isn't working as intended. For one, querying `peerChainState` seem to return abnormally high number of...

greymistcube

Change name/description for `IBlockPolicy<T>.BlockInterval`

2

Current property name and its description are misleading. Current implementation is a copy of https://eips.ethereum.org/EIPS/eip-2, but on closer inspection, the formula provided does not actually *target* `BlockInterval`.

greymistcube