libplanet

libplanet copied to clipboard

With #2294, unsignedTransaction query is redundant.

tkiapril

Currently, when calling `MakeTransaction()` for actions, we need to populate `updatedAddresses` by hand. This API may be prone to mistakes (omitting some updated addresses,) and may be automatically populated to...

tkiapril

Remove suppression: remove the unused local variable 'x' (#664)

2

resolved - #664 I removes the sonar analyzer suppression (remove unused local variable 'x') and resolves build errors that result from it.

sindydwns

The `timestamp` parameter isn't really intended to be used as part of the public API, but is only there to allow testing certain scenarios easier. At this point, however, it...

greymistcube

dahlia

While trying to get rid of `Peer` and streamline the initial "binding" process of an `ITransport`, in order to minimize API changes `NetMQTransport`'s `async` instantiation was implemented with `ConfigureAwait(false).GetAwaiter().GetResult()`. Aside...

greymistcube

#1955 suggests that "newly" introduced `StoreLoaderAttribute.LoadStore()` should work with an existing scheme, but I can't seem to get it to work. I only tried with default options for `rocksdb+file://` scheme...

greymistcube

NRE on `MigrateChainDBFromColumnFamilies()`

2

``` Unexpected exception occurred during Run. System.NullReferenceException: Object reference not set to an instance of an object. at Libplanet.RocksDBStore.RocksDBStoreBitConverter.ToInt64(Byte[] value) in /app/Lib9c/.Libplanet/Libplanet.RocksDBStore/RocksDBStoreBitConverter.cs:line 21 at Libplanet.RocksDBStore.RocksDBStore.MigrateChainDBFromColumnFamilies(String path) in /app/Lib9c/.Libplanet/Libplanet.RocksDBStore/RocksDBStore.cs:line 344 at...

longfin

Mnemonic code

7

Libplanet will be more useful for key management if it supports the mnemonic code follow [BIP-39]. [BIP-39]: https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki

longfin

Since some `FungibleAssetValue` like `GovernanceToken`, `ConsensusToken` and `Share` are same type, so it's a bit hard to handle. For example, it may increase chance to commit some mistakes, since it's...

OnedgeLee