Piotr Kuczynski
Piotr Kuczynski
> This is a breaking change as `binary_gender` could be used in `faker.faker('{{binary_gender}}')` without that we know it or users know that it had changed > I mark this as...
> TBH, I'm with you on this one. Never understood the use of fake at all. Gues its legacy from pre-v5.5. See my (same) comment https://github.com/faker-js/faker/pull/1161#issuecomment-1195852602 > Not "technically". In...
> Should we duplicate the binary_gender locale definition for now and remove it in v8? > That way we could merge this PR now and don't need to wait because...
Yeah, good point! How about `direction ({ abbr: boolean, types: DirectionType[] })` or `direction ({ abbr?: boolean, type?: DirectionType, except?: DirectionType[]})`
That's correct. But I guess more predictable. And unlikely someone would do it anyway. So we have the following proposals on the table, just to summarise: ```js direction ({ abbr?:...
We already discussed this with @hankucz and she will look at it. Thank you @wael-fadlallah
@Shinigami92 anything else missing to get this merged?
> Yes, all the v6.1 targeted things to be merged I assume 🤔 Not sure if we should be so stick to the _6.1 is only bug fixes_ as keeping...
Fair enough :)
We should definitely have a space where we could put all locale-independent definitions. Not sure we should call it `global` locale though as it's not connected with anything i18n. I...