Piotr Kuczynski
Piotr Kuczynski
I think currency should not come with a price. I might want to stay on `pl-PL` locale and still generate prices in €... Should I switch faker to `de` just...
@Shinigami92 what would be your suggestion then? `price` returns the string and fills with `0` if not enough precision is generated. Additionally, it offers to add a currency sign. https://fakerjs.dev/api/commerce.html#price
> I see this PR though... should I wait until that is merged? https://github.com/faker-js/faker/pull/276 In principle no changes like this will be merged until 6.0 is released. So I would...
> Since 6.0 was released, I'll continue with this one! Please don't. It has been already discussed and I am on it.
I would expect `faker.date.birthday` to have a bit different signature: ```js faker.date.birthday(age: number, refDate?: string | Date) faker.date.birthday(options: { min: number, max: number }, refDate?: string | Date) ``` So...
> Please migrate all js files to ts. I think it was an accidental commit of `lib/*` files...
General comment: you should separate zodiac signs and birthday into two separate PR, as they are totally independent.
> @pkuczynski Maybe from next time, I will target smaller issues/PRs. Too many commits have gone in this PR and it would be hard to undo those changes, split branches...
The issue is not only on `0.0001`. Another example: ``` faker.datatype.number({ precision: 0.000000001 }) > 43583.241103992004 ``` 12 precision points, when 9 was requested. Big.js is not a large library...
Any number would do for me as long as it works ;)